On Wed, Nov 9, 2011 at 6:02 AM, Martin Gerhard Loschwitz <[email protected]> wrote: > Hello everybody, > > I wrote an asterisk OCF resource agent which I am hereby putting up > for discussion. Any feedback is welcome. > > It's available from > https://github.com/fghaas/resource-agents/blob/master/heartbeat/asterisk
That URL 404'd for me. I found it in the asterisk branch, not master. https://github.com/fghaas/resource-agents/blob/asterisk/heartbeat/asterisk > I would like to get this integrated into the resource-agents package > so that it gets distributed automatically along with all the other > OCF RAs. I looked over this a bit. I'm no OCF expert, so I was mainly just looking at the Asterisk-isms. I think the main thing to think about here is the value the resource agent provides over what you would get with a more generic agent that just made sure the process stayed alive. What I'm seeing is the use of "asterisk -rx" to talk to Asterisk. I think that approach is a good and sane one. Here are some of my thoughts on potential improvements. asterisk -rx will help verify that the process isn't totally hosed for some reason. The specific command issued to Asterisk, "core show uptime", is unlikely to help detect any additional type of error, though. One improvement would be "core show channels". If just about anything locks up inside of Asterisk, it's going to eventually escalate to here, and will cause this command to fail. The one major caveat here is that it's not a command that should be run at a very high frequency. There are additional things that would be interesting to consider, but they get into technology specific health checks. For example, if SIP is being used, I would want to send it a simple SIP request (like OPTIONS) to make sure it is responding. -- Russell Bryant _______________________________________________ Linux-HA mailing list [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha See also: http://linux-ha.org/ReportingProblems
