On Tue, Dec 5, 2023 at 7:14 PM Vlastimil Babka <[email protected]> wrote: > > On 12/5/23 05:15, Hyeonggon Yoo wrote: > > On Mon, Nov 20, 2023 at 07:34:13PM +0100, Vlastimil Babka wrote: > > > > Looks good to me, > > Reviewed-by: Hyeonggon Yoo <[email protected]> > > Thanks. > > > Nit: > > > > - Some arch configs enables DEBUG_SLAB > > - Some documentations refers to {DEBUG_,}SLAB config (i.e. "enable > > DEBUG_SLAB for debugging", or "use SLUB instead of SLAB for reducing OS > > jitter", ... etc) > > - fs/orangefs/orangefs-kernel.h uses #if (defined CONFIG_DEBUG_SLAB) > > > > $ git grep DEBUG_SLAB arch/ > > arch/arm/configs/ep93xx_defconfig:CONFIG_DEBUG_SLAB=y > > arch/arm/configs/tegra_defconfig:CONFIG_DEBUG_SLAB=y > > arch/microblaze/configs/mmu_defconfig:CONFIG_DEBUG_SLAB=y > > > > $ git grep SLAB Documentation/ > > > > [... some unrelated lines removed ...] > > Yep, I've wrote in the cover letter that to keep the series reasonable and > limit Ccing other subsystems on some patches, not everything is cleaned up > thoroughly
Ah, I see, Okay. > and is left for further work (some already started coming in > from others) that can be submitted to relevant subsystems. I'll focus more on correctness rather than doing further work while reviewing. > > Documentation/admin-guide/cgroup-v1/cpusets.rst:PFA_SPREAD_SLAB, and > > appropriately marked slab caches will allocate > > Documentation/admin-guide/cgroup-v1/memory.rst: pages allocated by the > > SLAB or SLUB allocator are tracked. A copy > > Documentation/admin-guide/kernel-per-CPU-kthreads.rst: > > CONFIG_SLAB=y, thus avoiding the slab allocator's periodic > > Documentation/admin-guide/mm/pagemap.rst: The page is managed by the > > SLAB/SLUB kernel memory allocator. > > Documentation/dev-tools/kasan.rst:For slab, both software KASAN modes > > support SLUB and SLAB allocators, while > > Documentation/dev-tools/kfence.rst:of the sample interval, the next > > allocation through the main allocator (SLAB or > > Documentation/mm/slub.rst:The basic philosophy of SLUB is very different > > from SLAB. SLAB > > Documentation/mm/slub.rst: Sorry SLAB legacy issues) > > Documentation/process/4.Coding.rst: - DEBUG_SLAB can find a variety of > > memory allocation and use errors; it > > Documentation/process/submit-checklist.rst: ``CONFIG_DEBUG_SLAB``, > > ``CONFIG_DEBUG_PAGEALLOC``, ``CONFIG_DEBUG_MUTEXES``, > > Documentation/scsi/ChangeLog.lpfc: CONFIG_DEBUG_SLAB set). > > Documentation/translations/it_IT/process/4.Coding.rst: - DEBUG_SLAB può > > trovare svariati errori di uso e di allocazione di memoria; > > Documentation/translations/it_IT/process/submit-checklist.rst: > > ``CONFIG_DEBUG_SLAB``, ``CONFIG_DEBUG_PAGEALLOC``, ``CONFIG_DEBUG_MUTEXES``, > > Documentation/translations/ja_JP/SubmitChecklist:12: CONFIG_PREEMPT, > > CONFIG_DEBUG_PREEMPT, CONFIG_DEBUG_SLAB, > > Documentation/translations/zh_CN/dev-tools/kasan.rst:对于slab，两种软件KASAN模式都支持SLUB和SLAB分配器，而基于硬件标签的 > > Documentation/translations/zh_CN/process/4.Coding.rst: - DEBUG_SLAB > > 可以发现各种内存分配和使用错误；它应该用于大多数开发内核。 > > Documentation/translations/zh_CN/process/submit-checklist.rst: > > ``CONFIG_DEBUG_SLAB``, ``CONFIG_DEBUG_PAGEALLOC``, ``CONFIG_DEBUG_MUTEXES``, > > Documentation/translations/zh_TW/dev-tools/kasan.rst:對於slab，兩種軟件KASAN模式都支持SLUB和SLAB分配器，而基於硬件標籤的 > > Documentation/translations/zh_TW/process/4.Coding.rst: - DEBUG_SLAB > > 可以發現各種內存分配和使用錯誤；它應該用於大多數開發內核。 > > Documentation/translations/zh_TW/process/submit-checklist.rst: > > ``CONFIG_DEBUG_SLAB``, ``CONFIG_DEBUG_PAGEALLOC``, ``CONFIG_DEBUG_MUTEXES``, > > > > -- > > Hyeonggon >
