> -----Original Message----- > From: [email protected] <[email protected]> > > `strncpy` is deprecated for use on NUL-terminated destination strings [1] and > as > such we should prefer more robust and less ambiguous string interfaces. > > A suitable replacement is `strscpy` [2] due to the fact that it guarantees > NUL- > termination on the destination buffer without unnecessarily NUL-padding. > > host_info allocation is done in ena_com_allocate_host_info() via > dma_alloc_coherent() and is not zero initialized by alloc_etherdev_mq(). > > However zero initialization of the destination doesn't matter in this case, > because strscpy() guarantees a NULL termination. > > Link: > https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on- > nul-terminated-strings [1] > Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html > [2] > Link: https://github.com/KSPP/linux/issues/90 > Cc: [email protected] > Signed-off-by: Justin Stitt <[email protected]> > --- > Changes in v2: > - update commit message, dropping inaccurate statement about allocation > (thanks Arthur) > - copy/paste Arthur's explanation regarding host_info allocation into > - rebased onto mainline > - Link to v1: https://lore.kernel.org/r/20231005-strncpy-drivers-net-ethernet- > [email protected] > --- > Note: build-tested only. > --- > .................. > Best regards, > -- > Justin Stitt <[email protected]>
Thanks for making the necessary changes to the commit message Justin. Looks good. Acked-by: Arthur Kiyanovski <[email protected]>
