On Thu, Dec 14, 2023 at 09:06:12PM +0000, [email protected] wrote: > This patch includes linux/kernel.h in asm/word-at-a-time.h for the > sh architecture. WORD_AT_A_TIME_CONSTANTS depends on kernel.h. > Making this implicit dependancy explicit allows for later improvements > in the lib/string.c inclusion list. > > Suggested-by: Al Viro <[email protected]>
You forgot your SoB, but... ... > #ifdef CONFIG_CPU_BIG_ENDIAN > # include <asm-generic/word-at-a-time.h> > #else > +#include <linux/kernel.h> I highly discourage from doing that. Instead, split what is needed to the separate (new) header and include that one. > /* > * Little-endian version cribbed from x86. > */ -- With Best Regards, Andy Shevchenko
