On Tue, Dec 26, 2023 at 06:00:00PM +0000, Tanzir Hasan wrote: > This patch creates wordpart.h and includes it in asm/word-at-a-time.h > for all architectures. WORD_AT_A_TIME_CONSTANTS depends on kernel.h > because of REPEAT_BYTE. Moving this to another header and including it > where necessary allows us to not include the bloated kernel.h. Making > this implicit dependency on REPEAT_BYTE explicit allows for later > improvements in the lib/string.c inclusion list.
LGTM, and I hope this will not trigger CIs and other build checkers. Reviewed-by: Andy Shevchenko <[email protected]> ... > --- a/arch/powerpc/include/asm/word-at-a-time.h > +++ b/arch/powerpc/include/asm/word-at-a-time.h > @@ -4,8 +4,8 @@ > /* > * Word-at-a-time interfaces for PowerPC. > */ > - You can preserve this blank line... > -#include <linux/kernel.h> > +#include <linux/bitops.h> > +#include <linux/wordpart.h> ...here. > #include <asm/asm-compat.h> > #include <asm/extable.h> -- With Best Regards, Andy Shevchenko
