On Wed, Feb 07, 2024 at 12:51:51AM +0000, Justin Stitt wrote: > Hi, > > On Tue, Feb 06, 2024 at 06:22:18AM -0800, Kees Cook wrote: > > Similar to strscpy(), update strscpy_pad()'s 3rd argument to be > > optional when the destination is a compile-time known size array. > > This patch is diff'd against Patch 1/4 in this series, right? I wonder > why you split them up. If I hadn't literally just read that patch I > would be mildly confused. > > I suppose one reason may be that 1/4 is a standalone change with a high > percentage chance of landing whilst this overloading magic may not land > as easily?
I viewed it as a distinct logical change. I could certainly combine them, but I think it's easier to review the conversion from function to macro without needing to consider anything else. No behavioral changes are expected, etc. But if they were together, there's a little more cognitive load to keep the func/macro conversion in mind while looking at the optional arg magic, etc. I don't think it's a strict rule or anything; it just felt like the right thing to do to split them up. > At any rate, > Reviewed-by: Justin Stitt <[email protected]> Thanks! -Kees -- Kees Cook
