Re: [PATCH 2/2] net/ipv4: Annotate imsf_slist_flex with __counted_by(imsf_numsrc)

[Gustavo A. R. Silva]

On 2/9/24 19:16, Kees Cook wrote:

The size of the imsf_slist_flex member is determined by imsf_numsrc, so
annotate it as such.

Cc: "David S. Miller" <da...@davemloft.net>
Cc: Eric Dumazet <eduma...@google.com>
Cc: Jakub Kicinski <k...@kernel.org>
Cc: Paolo Abeni <pab...@redhat.com>
Cc: "Gustavo A. R. Silva" <gustavo...@kernel.org>
Cc: net...@vger.kernel.org
Cc: linux-hardening@vger.kernel.org
Signed-off-by: Kees Cook <keesc...@chromium.org>

LGTM:

Reviewed-by: Gustavo A. R. Silva <gustavo...@kernel.org>

Thanks!
--
Gustavo

---
  include/uapi/linux/in.h | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/uapi/linux/in.h b/include/uapi/linux/in.h
index e682ab628dfa..445f6ae76f1e 100644
--- a/include/uapi/linux/in.h
+++ b/include/uapi/linux/in.h
@@ -199,7 +199,8 @@ struct ip_msfilter {
        __u32           imsf_numsrc;
        union {
                __be32          imsf_slist[1];
-               __DECLARE_FLEX_ARRAY(__be32, imsf_slist_flex);
+               __DECLARE_FLEX_ARRAY_ATTR(__be32, imsf_slist_flex,
+                                         __counted_by(imsf_numsrc));
        };
  };