On Wed, 14 Feb 2024, Kees Cook <[email protected]> wrote: > On Wed, Feb 14, 2024 at 08:49:39PM +0200, Andy Shevchenko wrote: >> On Wed, Feb 14, 2024 at 08:30:53PM +0200, Jani Nikula wrote: >> > On Wed, 14 Feb 2024, Andy Shevchenko <[email protected]> >> > wrote: >> > > On Wed, Feb 14, 2024 at 08:08:16PM +0200, Andy Shevchenko wrote: >> > >> On Wed, Feb 14, 2024 at 05:50:15PM +0100, Michal Wajdeczko wrote: >> > >> > Add str_plural() helper to replace existing open implementations >> > >> > used by many drivers and help improve future user facing messages. >> > >> >> > >> Any user of this, please? >> > >> > git grep "\"\" *: *\"s\"" >> >> You know what I meant. >> Second patch in the series that shows usefulness of the first patch. > > Or a Coccinelle script that could do some rewrites? But, yes, if you can > include some examples, that would be nice. I think the helper is fine to > add.
In all kindness, I think it's actually better to get the inevitable bikeshedding rounds done first. It's trivial to add users after that. And for simple things like this it should really be obvious to everyone what the usage would be like. My first attempt at adding a plural helper seems to date back to 2019. Yes, really. Personally, I honestly can no longer be bothered to put in the extra effort before there's some indication of acceptance. (Like there's here now, thanks!) >> > >> > Signed-off-by: Michal Wajdeczko <[email protected]> >> > >> >> > >> > Cc: Andy Shevchenko <[email protected]> >> > >> > Cc: Jani Nikula <[email protected]> >> > >> >> > >> Move these Cc to the after '---' line. >> > >> > Why? >> >> At bare minimum to reduce noise in the commit message. >> If going further, to be environment friendly (no jokes). > > I learned the above-the-line CC habit from akpm. But in looking through > recent commit history, this does appear to be the exception now. I'll > need to adjust my own workflow for this too... It just depends on where in the kernel you look, every subsystem is subtly different. In the drm subsystem if you added the Cc's below "---", you might be asked to move them above. Trivial for whoever applies the patches to do whatever they please with the trailers, impossible for the contributor. It's like The Trial. :p BR, Jani. -- Jani Nikula, Intel
