Hi Kees, On Tue, Feb 27, 2024 at 11:47 PM Kees Cook <[email protected]> wrote: > For reasons I cannot understand, m68k moves the start of the stack frame > for consecutive calls to the same function if the function's test > variable is larger than 8 bytes. This was only happening for the char > array test (obviously), so adjust the length of the string for m68k > only. I want the array size to be longer than "unsigned long" for every > given architecture, so the other remain unchanged. > > Additionally adjust the error message to be a bit more clear about > what's happened, and move the KUNIT check outside of the consecutive > calls to minimize what happens between them.
Thanks for your patch! > Reported-by: Guenter Roeck <[email protected]> > Closes: > https://lore.kernel.org/lkml/[email protected]/ Do reports have an expiration date? ;-) Reported-by: Geert Uytterhoeven <[email protected]> Closes: https://lore.kernel.org/r/camuhmdx_g1tbiul9puqdqaegrezcnn3gtbsvsbfyal4tzvs...@mail.gmail.com Closes: https://lore.kernel.org/r/camuhmdw6n40+0ggq+lsrn64mo4a0-elam0pr3gwq0mnanyb...@mail.gmail.com > Signed-off-by: Kees Cook <[email protected]> Finally all parts of this test are passing on m68k, great! Tested-by: Geert Uytterhoeven <[email protected]> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
