On Sat, 2 Mar 2024 at 03:40, Mickaël Salaün <[email protected]> wrote: > > Previously, if a thread creation failed (e.g. -ENOMEM), the function was > called (kunit_catch_run_case or kunit_catch_run_case_cleanup) without > marking the test as failed. Instead, fill try_result with the error > code returned by kthread_run(), which will mark the test as failed and > print "internal error occurred...". > > Cc: Brendan Higgins <[email protected]> > Cc: David Gow <[email protected]> > Cc: Rae Moar <[email protected]> > Cc: Shuah Khan <[email protected]> > Reviewed-by: Kees Cook <[email protected]> > Signed-off-by: Mickaël Salaün <[email protected]> > Link: https://lore.kernel.org/r/[email protected] > --- > > Changes since v1: > * Added Kees's Reviewed-by. > ---
Thanks for catching this! Reviewed-by: David Gow <[email protected]> Thanks, -- David -- David > lib/kunit/try-catch.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/kunit/try-catch.c b/lib/kunit/try-catch.c > index f7825991d576..a5cb2ef70a25 100644 > --- a/lib/kunit/try-catch.c > +++ b/lib/kunit/try-catch.c > @@ -69,6 +69,7 @@ void kunit_try_catch_run(struct kunit_try_catch *try_catch, > void *context) > try_catch, > "kunit_try_catch_thread"); > if (IS_ERR(task_struct)) { > + try_catch->try_result = PTR_ERR(task_struct); > try_catch->catch(try_catch->context); > return; > } > -- > 2.44.0 >
smime.p7s
Description: S/MIME Cryptographic Signature
