On 2024/3/20 11:34, Matthew Wilcox wrote:
> On Wed, Mar 20, 2024 at 11:30:13AM +0800, Jiangfeng Xiao wrote:
>> The checkpatch.pl script reports the "WARNING: printk() should
>> include KERN_<LEVEL> facility level" warning.
>>
>> That's why I changed printk to pr_warn.
>> I should change printk to printk(KERN_DEFAULT).
>
> No, you should ignore checkpatch. For bonus points, figure out why you
> should ignore it specifically in this case.
> .
>
Thank you. I think I understand.
The checkpatch.pl file is a false report
because the 'loglvl' already exists.
I'd better keep printk(" %s...", loglvl, ...) still.
- Re: [PATCH] usercopy: dele... Russell King (Oracle)
- Re: [PATCH] usercopy: dele... Josh Poimboeuf
- RE: [PATCH] usercopy: dele... David Laight
- Re: [PATCH] usercopy: dele... Jiangfeng Xiao
- Re: [PATCH] usercopy: delete __noreturn from us... Jiangfeng Xiao
- Re: [PATCH] usercopy: delete __noreturn fro... Jiangfeng Xiao
- [PATCH] ARM: unwind: improve unwinders for noreturn ... Jiangfeng Xiao
- Re: [PATCH] ARM: unwind: improve unwinders for ... Kees Cook
- Re: [PATCH] ARM: unwind: improve unwinders ... Jiangfeng Xiao
- Re: [PATCH] ARM: unwind: improve unwind... Matthew Wilcox
- Re: [PATCH] ARM: unwind: improve un... Jiangfeng Xiao
- [PATCH v2] ARM: unwind: improve unwinders for noretu... Jiangfeng Xiao
- Re: [PATCH v2] ARM: unwind: improve unwinders f... Russell King (Oracle)
- Re: [PATCH v2] ARM: unwind: improve unwinde... Jiangfeng Xiao
- Re: [PATCH v2] ARM: unwind: improve unw... Russell King (Oracle)
- Re: [PATCH v2] ARM: unwind: improve... Jiangfeng Xiao
- RE: [PATCH v2] ARM: unwind: im... David Laight
- Re: [PATCH v2] ARM: unwind... Russell King (Oracle)
- RE: [PATCH v2] ARM: unwind... David Laight
- Re: [PATCH v2] ARM: unwind... Russell King (Oracle)
- RE: [PATCH v2] ARM: unwind... David Laight
