On Mon, Apr 08, 2024 at 09:01:57PM +0000, Justin Stitt wrote: > This pattern of strncpy with some pointer arithmetic setting fixed-sized > intervals with string literal data is a bit weird so let's use > ethtool_puts() as this has more obvious behavior and is less-error > prone. > > Nicely, we also get to drop a usage of the now deprecated strncpy() [1]. > > Link: > https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings > [1] > Link: https://github.com/KSPP/linux/issues/90 > Cc: [email protected] > Cc: Kees Cook <[email protected]> > Signed-off-by: Justin Stitt <[email protected]>
Reviewed-by: Kees Cook <[email protected]> -- Kees Cook
