Re: [PATCH] arm64: smp: smp_send_stop() and crash_smp_send_stop() should try non-NMI first

[Will Deacon]

On Fri, May 17, 2024 at 01:01:58PM -0700, Doug Anderson wrote:
> On Thu, Dec 7, 2023 at 5:03 PM Douglas Anderson <diand...@chromium.org> wrote:
> >         local_irq_disable();
> 
> The above local_irq_disable() is not new for my patch but it seems
> wonky for two reasons:
> 
> 1. It feels like it should have been the first thing in the function.
> 
> 2. It feels like it should be local_daif_mask() instead.

Is that to ensure we don't take a pNMI? I think that makes sense, but
let's please add a comment to say why local_irq_disable() is not
sufficient.

Will