From: André Apitzsch <[email protected]>

The phone has a Silergy SY7802 flash LED controller.

Reviewed-by: Konrad Dybcio <[email protected]>
Signed-off-by: André Apitzsch <[email protected]>
---
This series introduces a driver for the Silergy SY7802 charge pump used
in the BQ Aquaris M5 and X5 smartphones.

The implementation is based on information extracted from downstream as
the datasheet provided by a distributor of the hardware didn't include
any information about the i2c register description.
---
Changes in v6:
- Drop applied patches 1/3 and 2/3
- Move #address-/size-cells to the end
- Add R-b tag
- Link to v5: 
https://lore.kernel.org/r/[email protected]

Changes in v5:
- Fix language in driver description comment
- Unwrap function arguments
- Remove unnecessary empty lines
- Add Acked-by tag to second patch
- Link to v4: 
https://lore.kernel.org/r/[email protected]

Changes in v4:
- Use for_each_available_child_of_node_scoped() to simplify code
- Use dev_err_probe() to be consistent with the other code in
  sy7802_probe()
- Split devm_add_action() into 2 devm_add_action_or_reset() to simplify
  code and balance regulator_enable()
- Link to v3: 
https://lore.kernel.org/r/[email protected]

Changes in v3:
- Add R-b tag to first patch
- Extend driver commit message
- Improve readability of defines by using BIT()
- Rename some variables/parameters
  * led_no -> led_id
  * level -> brightness
  * curr -> fled_{strobe,torch}_used_tmp
  * mask -> {flash,torch}_mask
  * i -> child_num
- Restructure structs ("Place th big stuff at the top")
- Declare 'child' on a separate line
- Move multi-line assignments out of declaration block
- Update warning/error messages and comments
- Use gotos to handle error path
- Use devm API to cleanup module's resources
- Init mutex before LED class device is registered to avoid race
  condition
- Link to v2: 
https://lore.kernel.org/r/[email protected]

Changes in v2:
- bindings: remove unneeded allOf
- bindings: example: move flash-led-controller under i2c node to fix
  check error
- Cc to phone-devel
- Link to v1: 
https://lore.kernel.org/r/[email protected]
---
 .../boot/dts/qcom/msm8939-longcheer-l9100.dts      | 27 ++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts 
b/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts
index e3404c4455cf..b845da4fa23e 100644
--- a/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts
+++ b/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts
@@ -159,6 +159,26 @@ led@2 {
                        };
                };
        };
+
+       flash-led-controller@53 {
+               compatible = "silergy,sy7802";
+               reg = <0x53>;
+
+               enable-gpios = <&tlmm 16 GPIO_ACTIVE_HIGH>;
+
+               pinctrl-0 = <&camera_rear_flash_default>;
+               pinctrl-names = "default";
+
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               led@0 {
+                       reg = <0>;
+                       function = LED_FUNCTION_FLASH;
+                       color = <LED_COLOR_ID_WHITE>;
+                       led-sources = <0>, <1>;
+               };
+       };
 };
 
 &blsp_i2c3 {
@@ -318,6 +338,13 @@ camera_front_flash_default: 
camera-front-flash-default-state {
                bias-disable;
        };
 
+       camera_rear_flash_default: camera-rear-flash-default-state {
+               pins = "gpio9", "gpio16", "gpio51";
+               function = "gpio";
+               drive-strength = <2>;
+               bias-disable;
+       };
+
        gpio_hall_sensor_default: gpio-hall-sensor-default-state {
                pins = "gpio20";
                function = "gpio";

---
base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233
change-id: 20240325-sy7802-f40fc6f56525

Best regards,
-- 
André Apitzsch <[email protected]>



Reply via email to