On Tue, Aug 27, 2024 at 04:42:18PM -0700, Andrew Morton wrote: > On Tue, 27 Aug 2024 10:45:15 +0800 Hongbo Li <[email protected]> wrote:
... > > +#define str_false_true(v) str_true_false(!(v)) > This might result in copies of the strings "true" and "false" being > generated for every .c file which uses this function, resulting in > unnecessary bloat. > > It's possible that the compiler/linker can eliminate this duplication. > If not, I suggest that every function in string_choices.h be uninlined. >From this perspective this patch doesn't change anything. The function is inline and in the same compilation module the linker will optimise away the duplicates (note as well that this is kinda new feature, some relatively old GCC might not have this feature, but I'm not an expert in the area). -- With Best Regards, Andy Shevchenko
