On Sat, Aug 31, 2024 at 01:07:41PM -0700, Jakub Kicinski wrote: > On Sat, 31 Aug 2024 17:58:38 +0800 Hongbo Li wrote: > > Use str_disabled_enabled() helper instead of open > > coding the same.
... > > netif_info(tun, drv, tun->dev, "ignored: set checksum %s\n", > > - arg ? "disabled" : "enabled"); > > + str_disabled_enabled(arg)); > > You don't explain the 'why'. How is this an improvement? > nack on this and 2 similar networking changes you sent Side opinion: This makes the messages more unified and not prone to typos and/or grammatical mistakes. Unification allows to shrink binary due to linker efforts on string literals deduplication. That said, I see an improvement here, however it might be not recognised as a Big Win. And yes, I agree on the commit message poor explanations. -- With Best Regards, Andy Shevchenko
