On Tue, 2024-12-10 at 17:39 +0300, Dmitry Antipov wrote: > Simplify 'cfg80211_mlme_register_mgmt()' to allocate an instance of > 'struct cfg80211_mgmt_registration' only if the latter is really > neededÂ
This part is very much broken, and I don't see that it's actually useful to add a new "goto" just for the (unlikely) case of not needing the allocation. > (i.e. when the list of registrations should be updated) > and prefer 'kmalloc()' over 'kzalloc()' since all of the members > are explicitly initialized. This part I disagree with, who knows what we might add. This isn't a path where we might possibly care about the cost of zeroing, vs. the added maintenance requirement. johannes
