On Thu, Feb 06, 2025 at 10:52:18AM -0800, Kees Cook wrote: > On Thu, Feb 06, 2025 at 08:45:41PM +0200, Andy Shevchenko wrote: > > On Thu, Feb 6, 2025 at 8:44 PM Miguel Ojeda > > <[email protected]> wrote: > > > On Thu, Feb 6, 2025 at 7:42 PM Andy Shevchenko > > > <[email protected]> wrote: > > > > > > > > What's the minimum Clang version we build kernel with? 12? > > > > > > 13.0.1 for most architectures according to `scripts/min-tool-version.sh`. > > > > Okay, does it mean 13 has no such a bug? > > It probably did, but Clang 13 didn't support compile-time error messages > (added in 14). Regardless, this fixes it there and makes the API more > robust. > > > Otherwise the commit message and other comments might be clearer... > > How should I rephrase things? I mention the bug and when it was fixed > in patch 3: > > ... > benefit of working around a bug in Clang (fixed[1] in 15+) that got > ...
Ah, the version is mentioned only in cover letter. So, the patch's commit message seems good to me. -- With Best Regards, Andy Shevchenko
