I wanted to check in on this. Anything I need to change? Thanks, Ethan
On 25/01/19 01:35PM, Ethan Carter Edwards wrote: > We are replacing any instances of kzalloc(size * count, ...) with > kcalloc(count, size, ...) due to risk of overflow [1]. > > [1] > https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments > Link: https://github.com/KSPP/linux/issues/162 > > Signed-off-by: Ethan Carter Edwards <[email protected]> > --- > v3: fix description and email client formatting > v2: fix typo > drivers/thermal/thermal_debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/thermal_debugfs.c > b/drivers/thermal/thermal_debugfs.c > index c800504c3cfe..29dc1431a252 100644 > --- a/drivers/thermal/thermal_debugfs.c > +++ b/drivers/thermal/thermal_debugfs.c > @@ -876,7 +876,7 @@ void thermal_debug_tz_add(struct thermal_zone_device *tz) > > tz_dbg->tz = tz; > > - tz_dbg->trips_crossed = kzalloc(sizeof(int) * tz->num_trips, > GFP_KERNEL); > + tz_dbg->trips_crossed = kcalloc(tz->num_trips, sizeof(int), GFP_KERNEL); > if (!tz_dbg->trips_crossed) { > thermal_debugfs_remove_id(thermal_dbg); > return; > -- > 2.47.1 >
