On Mon, Jun 23, 2025 at 03:28:27PM +0900, Naoya Tezuka wrote: > The Reed-Solomon library enforces the constraint `n <= 2^m - 1` via a > BUG_ON() [1], where `n` is `block_size + ecc_size` and `m` is `symsize` > for the pstore RAM backend. A driver providing invalid parameters can > trigger this, leading to a kernel panic. For more details on the theory > behind, see [2]. > > This issue was discovered during developing chromeos_pstore driver. > Link: > https://lore.kernel.org/lkml/[email protected]/
I'd prefer to unify it by using a [3] or at least move the tag to the end of commit message. > Add a check to validate this constraint before initializing Reed-Solomon > codec. On failure, return -EINVAL to prevent the panic. > > [1] > https://elixir.bootlin.com/linux/v6.15/source/lib/reed_solomon/decode_rs.c#L43 > [2] https://www.cs.cmu.edu/~guyb/realworld/reedsolomon/reed_solomon_codes.html > > Signed-off-by: Naoya Tezuka <[email protected]> It should preserve my R-b tag as v2 doesn't change too much. Anyway, Reviewed-by: Tzung-Bi Shih <[email protected]>
