On Thu, Jul 17, 2025 at 10:53 AM Kees Cook <k...@kernel.org> wrote: > > Add support for Clang's coming "kcfi_salt" attribute, which is designed > to allow for KCFI prototype hashes to be separated[1]. For example, > normally two "void func(void)" functions would have the same KCFI hash, > but if they wanted their indirect calls to be distinguishable by KCFI, > one could add __kcfi_salt("foo").
It would be nice to have a quick sentence inline summarizing how it will be used, e.g. what kind of functions will need to be annotated. > To test the result, add a corresponding LKDTM test, CFI_FORWARD_SALT. Sounds good. > + * clang: https://clang.llvm.org/docs/AttributeReference.html#kcfi-salt I guess this anchor will eventually work -- I see you asked about it at: https://github.com/llvm/llvm-project/pull/141846#discussion_r2209236363 >From what I see, this still has to land in LLVM, right? So I guess there is still time to land this (and the discussion started years ago), but if you need to take it quickly as a base for some other work or similar: Acked-by: Miguel Ojeda <oj...@kernel.org> Cheers, Miguel