On Thu, 2025-07-17 at 22:59 +0800, Leo Wang wrote:
> From: Leo Wang <leo.jt.w...@gmail.com>
>
> Add linux device tree entry for Meta Clemente compute-tray
> BMC using AST2600 SoC.
>
> Signed-off-by: Leo Wang <leo.jt.w...@gmail.com>
>
[...]
> + };
> +
> +// PDB TEMP SENSOR
This comment should be indented appropriately?
> + temperature-sensor@4e {
> + compatible = "ti,tmp1075";
> + reg = <0x4e>;
> + };
>
[...]
> +
> +&i2c11 {
> + status = "okay";
> + aspeed,enable-byte;
This is not a property specified in any accepted binding, please drop
it.
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-clemente.dtb: i2c@600
(aspeed,ast2600-i2c-bus): Unevaluated properties are not allowed
('aspeed,enable-byte' was unexpected)
from schema $id: http://devicetree.org/schemas/i2c/aspeed,i2c.yaml#
> +
> + ssif-bmc@10 {
> + compatible = "ssif-bmc";
> + reg = <0x10>;
> + };
> +};
>
[...]
> +
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-g6-pinctrl.dtsi
> b/arch/arm/boot/dts/aspeed/aspeed-g6-pinctrl.dtsi
> index
> 289668f051eb4271ac48ae3ce9b82587911548ee..61b1d1c5040c820f8c995132739becde80e069bb
> 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-g6-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/aspeed/aspeed-g6-pinctrl.dtsi
> @@ -412,6 +412,16 @@ pinctrl_mdio4_default: mdio4_default {
> groups = "MDIO4";
> };
>
> + pinctrl_ncsi3_default: ncsi3_default {
> + function = "RMII3";
> + groups = "NCSI3";
> + };
> +
> + pinctrl_ncsi4_default: ncsi4_default {
> + function = "RMII4";
> + groups = "NCSI4";
> + };
> +
Can you please make this a separate patch?
Thanks,
Andrew
