> Why not use readl() and writel() directly? > To make it easier to add debug prints during initial development?
Yes. And ultimately, there is a patch in the works converting the driver to MMIO regmap to get rid of _all_ the helpers. I couldn't make this in time for the 6.17 mergewindow, though, because of... gory details.