On Wed, Oct 22, 2025 at 03:10:40PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <[email protected]>
> 
> Implement a function for checking if a string ends with a different
> string and add its kunit test cases.

...

> +static void string_test_strends(struct kunit *test)
> +{
> +     KUNIT_EXPECT_TRUE(test, strends("foo-bar", "bar"));
> +     KUNIT_EXPECT_TRUE(test, strends("foo-bar", "-bar"));
> +     KUNIT_EXPECT_TRUE(test, strends("foobar", "foobar"));
> +     KUNIT_EXPECT_TRUE(test, strends("foobar", ""));
> +     KUNIT_EXPECT_FALSE(test, strends("bar", "foobar"));
> +     KUNIT_EXPECT_FALSE(test, strends("", "foo"));
> +     KUNIT_EXPECT_FALSE(test, strends("foobar", "ba"));
> +     KUNIT_EXPECT_TRUE(test, strends("", ""));
> +}

Have you checked the binary file? If you want this to be properly implemented,
generate the suffix. (Actually making the function static inline makes my point
really visible)

-- 
With Best Regards,
Andy Shevchenko



Reply via email to