On Tue, Nov 18, 2025 at 11:09 AM Andy Shevchenko <[email protected]> wrote: > > On Tue, Nov 18, 2025 at 12:04 PM Bartosz Golaszewski <[email protected]> wrote: > > > A couple follow-up changes to the new strends() string helper. This > > needs to go through the GPIO tree as this is where the strends() > > currently is. > > It appears that due to some local issue my messages from the last 8 > days disappeared and seemed to never be delivered. I tried to review > your v4 again and I have comments on this and patch 3. For the > strends() I proposed to get rid of strlen() calls by > > char *p; > > p = strrchr(str, suffix[0[); > if (!p) > return false; > > return strcmp(p, suffix) == 0; >
IMO that's a bit less readable. Unless you benchmark it and show it's faster than the current version, I'd say: let's keep the current implementation. Bart
