On Thu, 2026-01-08 at 22:05 +0200, Andy Shevchenko wrote: > 1) inherited one with strange indentation;
Hm...where? AFAICS everything is properly indented with TABs. > 2) missing Return section (run kernel-doc validator with -Wreturn, > for example). Good point. Should checkpatch.pl call kernel-doc (always or perhaps if requested using command-line option)? OTOH 1) lib/cmdline.c violates kernel-doc -Wreturn almost everywhere :-( and 2) IIUC this patch is already queued by Andrew. I would prefer to fix kernel-doc glitches immediately after memvalue() and its first real use case (presumably XFS) both reaches an upstream. Dmitry
