On Thu, Feb 12, 2026 at 02:32:39PM +0000, David Laight wrote:
> On Thu, 12 Feb 2026 15:41:59 +0200
> Andy Shevchenko <[email protected]> wrote:
> > On Thu, Feb 12, 2026 at 03:56:24PM +0300, Dmitry Antipov wrote:
...
> > > + for (rv = 0; max_chars--; rv++, s++) {
> >
> > Hmm... is max_chars being used inside for-loop body? I would rather use
> > regular
> > pattern here:
> >
> > for (rv = 0; rv < max_chars; rv++, s++) {
> >
> > (just check that any integer / sign promotion doesn't change the logic).
>
> The 'problem' is that the loop sets 'OVERFLOW' in rv.
Ah, true...
--
With Best Regards,
Andy Shevchenko
