On Thu, May 07, 2026 at 01:10:03PM +0200, Johannes Berg wrote: > On Thu, 2026-05-07 at 19:03 +0800, Jiazi Li wrote: > > Currently finds 4 locations: > > ./drivers/net/wireless/realtek/rtw89/fw.c:2557:7-12: opportunity for > > str_alloc_free(valid) > > ./drivers/net/wireless/realtek/rtw89/fw.c:2693:7-12: opportunity for > > str_alloc_free(valid) > > ./drivers/android/tests/binder_alloc_kunit.c:196:6-21: opportunity for > > str_alloc_free(alloc -> pages [ i ]) > > ./mm/slub.c:1634:3-8: opportunity for str_alloc_free(alloc) > > It's what, three characters shorter for four users each? Is there really > much point? > > Reading just the name also is really confusing - yes it lines up with > str_assert_deassert, but "alloc_free" really doesn't seem very obvious - > why would you alloc and free a string in one function call?
Yeah, there seems to only be 1 source file instance of this? I don't think this needs the entire helper infrastructure. -- Kees Cook
