On Fri, Dec 09, 2016 at 04:25:48PM +0100, Jean Delvare wrote: > On Fri, 9 Dec 2016 06:22:43 -0800, Guenter Roeck wrote: > > On 12/09/2016 01:49 AM, Jean Delvare wrote: > > > Looking at function nct7802_write_fan_min() I think an overflow can > > > happen here too, as DIV_ROUND_CLOSEST() is called before clamp_val(). > > > Any reason why you did not fix that one? > > > > > Not really. The call is > > DIV_ROUND_CLOSEST(1350000U, limit); > > and thus won't overflow. > > Limit is originally parsed by kstrtoul into an unsigned long, however > the nct7802_write_fan_min function parameter is an unsigned int, so it > is implicitly cast to an unsigned int. On a 32-bit system, that may not > fit? > Good point. My module test doesn't catch that. Let me have a look if I can somehow trigger that failure.
Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
