Hello Guenter

Thank you for your fast review!

> The driver must now support I2C_FUNC_I2C which is a significant change in 
> functionality
> since it will no longer work on SMBus-only adapters.

You are right of course, I wasn't aware of that.

> You'll have to find a better
> solution, one that retains the old functionality but also works on the 
> Raspberry Pi.

What are my options? A separate driver (sht21nhm) would probably not be 
accepted, right?

Or should I instead try to submit it to the Raspberry Pi kernel tree directly?

> FWIW, this should really be solved in the infrastructure. Many devices 
> support and
> depend on clock stretching, and we can not mess up the drivers for all those 
> devices
> to deal with a broken adapter.

Could you elaborate what you mean with "in the infrastructure"? Could there be a
way to solve this on the i2c / adapter driver level?

An interesting sidenote is that the driver used to work on the Raspberry Pi with
older kernel versions, but not on current ones. (I'd have to look up the exact
versions, but I think it changed sometime last year.) Maybe something about the
timing was changed that broke clock stretching.

> Has this been discussed on the i2c mailing list ?

I did not submit a discussion so far, and the mailing list search did not
turn up anything related. Should I start a discussion there?

Cheers and thanks for your time,
Danilo Bargen
--
To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to