Hi Christopher, Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc5 next-20180315] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Eddie-James/hwmon-ucd9000-Add-gpio-and-debugfs-interfaces/20180316-125048 config: x86_64-randconfig-x017-201810 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/hwmon/pmbus/ucd9000.c: In function 'ucd9000_probe': >> drivers/hwmon/pmbus/ucd9000.c:457:12: error: 'struct gpio_chip' has no >> member named 'of_node' data->gpio.of_node = client->dev.of_node; ^ vim +457 drivers/hwmon/pmbus/ucd9000.c 308 309 static int ucd9000_probe(struct i2c_client *client, 310 const struct i2c_device_id *id) 311 { 312 u8 block_buffer[I2C_SMBUS_BLOCK_MAX + 1]; 313 struct ucd9000_data *data; 314 struct pmbus_driver_info *info; 315 const struct i2c_device_id *mid; 316 enum chips chip; 317 int i, ret; 318 319 if (!i2c_check_functionality(client->adapter, 320 I2C_FUNC_SMBUS_BYTE_DATA | 321 I2C_FUNC_SMBUS_BLOCK_DATA)) 322 return -ENODEV; 323 324 ret = i2c_smbus_read_block_data(client, UCD9000_DEVICE_ID, 325 block_buffer); 326 if (ret < 0) { 327 dev_err(&client->dev, "Failed to read device ID\n"); 328 return ret; 329 } 330 block_buffer[ret] = '\0'; 331 dev_info(&client->dev, "Device ID %s\n", block_buffer); 332 333 for (mid = ucd9000_id; mid->name[0]; mid++) { 334 if (!strncasecmp(mid->name, block_buffer, strlen(mid->name))) 335 break; 336 } 337 if (!mid->name[0]) { 338 dev_err(&client->dev, "Unsupported device\n"); 339 return -ENODEV; 340 } 341 342 if (client->dev.of_node) 343 chip = (enum chips)of_device_get_match_data(&client->dev); 344 else 345 chip = id->driver_data; 346 347 if (chip != ucd9000 && chip != mid->driver_data) 348 dev_notice(&client->dev, 349 "Device mismatch: Configured %s, detected %s\n", 350 id->name, mid->name); 351 352 data = devm_kzalloc(&client->dev, sizeof(struct ucd9000_data), 353 GFP_KERNEL); 354 if (!data) 355 return -ENOMEM; 356 info = &data->info; 357 358 ret = i2c_smbus_read_byte_data(client, UCD9000_NUM_PAGES); 359 if (ret < 0) { 360 dev_err(&client->dev, 361 "Failed to read number of active pages\n"); 362 return ret; 363 } 364 info->pages = ret; 365 if (!info->pages) { 366 dev_err(&client->dev, "No pages configured\n"); 367 return -ENODEV; 368 } 369 370 /* The internal temperature sensor is always active */ 371 info->func[0] = PMBUS_HAVE_TEMP; 372 373 /* Everything else is configurable */ 374 ret = i2c_smbus_read_block_data(client, UCD9000_MONITOR_CONFIG, 375 block_buffer); 376 if (ret <= 0) { 377 dev_err(&client->dev, "Failed to read configuration data\n"); 378 return -ENODEV; 379 } 380 for (i = 0; i < ret; i++) { 381 int page = UCD9000_MON_PAGE(block_buffer[i]); 382 383 if (page >= info->pages) 384 continue; 385 386 switch (UCD9000_MON_TYPE(block_buffer[i])) { 387 case UCD9000_MON_VOLTAGE: 388 case UCD9000_MON_VOLTAGE_HW: 389 info->func[page] |= PMBUS_HAVE_VOUT 390 | PMBUS_HAVE_STATUS_VOUT; 391 break; 392 case UCD9000_MON_TEMPERATURE: 393 info->func[page] |= PMBUS_HAVE_TEMP2 394 | PMBUS_HAVE_STATUS_TEMP; 395 break; 396 case UCD9000_MON_CURRENT: 397 info->func[page] |= PMBUS_HAVE_IOUT 398 | PMBUS_HAVE_STATUS_IOUT; 399 break; 400 default: 401 break; 402 } 403 } 404 405 /* Fan configuration */ 406 if (mid->driver_data == ucd90124) { 407 for (i = 0; i < UCD9000_NUM_FAN; i++) { 408 i2c_smbus_write_byte_data(client, 409 UCD9000_FAN_CONFIG_INDEX, i); 410 ret = i2c_smbus_read_block_data(client, 411 UCD9000_FAN_CONFIG, 412 data->fan_data[i]); 413 if (ret < 0) 414 return ret; 415 } 416 i2c_smbus_write_byte_data(client, UCD9000_FAN_CONFIG_INDEX, 0); 417 418 info->read_byte_data = ucd9000_read_byte_data; 419 info->func[0] |= PMBUS_HAVE_FAN12 | PMBUS_HAVE_STATUS_FAN12 420 | PMBUS_HAVE_FAN34 | PMBUS_HAVE_STATUS_FAN34; 421 } 422 423 /* 424 * Note: 425 * 426 * Pinmux support has not been added to the new gpio_chip. 427 * This support should be added when possible given the mux 428 * behavior of these IO devices. 429 */ 430 data->gpio.label = (const char *)&client->name; 431 data->gpio.get_direction = ucd9000_gpio_get_direction; 432 data->gpio.direction_input = ucd9000_gpio_direction_input; 433 data->gpio.direction_output = ucd9000_gpio_direction_output; 434 data->gpio.get = ucd9000_gpio_get; 435 data->gpio.set = ucd9000_gpio_set; 436 data->gpio.can_sleep = 1; 437 data->gpio.base = -1; 438 439 switch (mid->driver_data) { 440 case ucd9090: 441 data->gpio.ngpio = UCD9090_NUM_GPIOS; 442 break; 443 case ucd90120: 444 case ucd90124: 445 case ucd90160: 446 data->gpio.ngpio = UCD901XX_NUM_GPIOS; 447 break; 448 case ucd90910: 449 data->gpio.ngpio = UCD90910_NUM_GPIOS; 450 break; 451 default: 452 break; 453 } 454 455 data->gpio.parent = &client->dev; 456 data->gpio.owner = THIS_MODULE; > 457 data->gpio.of_node = client->dev.of_node; 458 459 if (data->gpio.ngpio) { 460 ret = devm_gpiochip_add_data(&client->dev, &data->gpio, 461 client); 462 if (ret) 463 dev_warn(&client->dev, "Could not add gpiochip: %d\n", 464 ret); 465 } 466 467 return pmbus_do_probe(client, mid, info); 468 } 469 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
