Hi Matt,

I love your patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.18-rc2 next-20180625]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Matt-Ranostay/media-video-i2c-add-hwmon-support-for-amg88xx/20180626-151137
base:   git://linuxtv.org/media_tree.git master
config: x86_64-randconfig-x014-201825 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

>> drivers/media//i2c/video-i2c.c:183:17: error: lvalue required as unary '&' 
>> operand
      .hwmon_init = &amg88xx_hwmon_init,
                    ^

vim +183 drivers/media//i2c/video-i2c.c

   174  
   175  static const struct video_i2c_chip video_i2c_chip[] = {
   176          [AMG88XX] = {
   177                  .size           = &amg88xx_size,
   178                  .format         = &amg88xx_format,
   179                  .max_fps        = 10,
   180                  .buffer_size    = 128,
   181                  .bpp            = 16,
   182                  .xfer           = &amg88xx_xfer,
 > 183                  .hwmon_init     = &amg88xx_hwmon_init,
   184          },
   185  };
   186  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to