There is nothing critically wrong to read these two attributes
without having a is_enabled() check at this point. But reading
the MASK_ENABLE register would clear the CVRF bit according to
the datasheet. So it'd be safer to fence for disabled channels
in order to add pm runtime feature.

Signed-off-by: Nicolin Chen <[email protected]>
---
 drivers/hwmon/ina3221.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/hwmon/ina3221.c b/drivers/hwmon/ina3221.c
index d61688f04594..3e98b59108ee 100644
--- a/drivers/hwmon/ina3221.c
+++ b/drivers/hwmon/ina3221.c
@@ -200,6 +200,8 @@ static int ina3221_read_curr(struct device *dev, u32 attr,
                return 0;
        case hwmon_curr_crit_alarm:
        case hwmon_curr_max_alarm:
+               if (!ina3221_is_enabled(ina, channel))
+                       return -ENODATA;
                ret = regmap_field_read(ina->fields[reg], &regval);
                if (ret)
                        return ret;
-- 
2.17.1

Reply via email to