> On Apr 19, 2019, at 11:36, kbuild test robot <[email protected]> wrote:
>
>>> drivers/hwmon/max6650.c:798:10: warning: passing argument 2 of
>>> 'thermal_of_cooling_device_register' discards 'const' qualifier from
>>> pointer target type [-Wdiscarded-qualifiers]
> id->name, data,
> ^~
> In file included from drivers/hwmon/max6650.c:43:0:
> include/linux/thermal.h:448:1: note: expected 'char *' but argument is of
> type 'const char *'
> thermal_of_cooling_device_register(struct device_node *np, char *, void *,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Hmmm... I forgot I was indeed using a patched version of
thermal_of_cooling_device_register (submitted already:
https://marc.info/?l=linux-pm&m=155560541430929&w=2)
I will v5 using client->name instead, which is non-const char[].
> In file included from include/linux/i2c.h:30:0,
> from drivers/hwmon/max6650.c:38:
>>> drivers/hwmon/max6650.c:802:5: warning: format '%d' expects argument of
>>> type 'int', but argument 3 has type 'long int' [-Wformat=]
> "thermal cooling device register failed: %d\n",
> ^
> include/linux/device.h:1400:22: note: in definition of macro 'dev_fmt'
> #define dev_fmt(fmt) fmt
> ^~~
>>> drivers/hwmon/max6650.c:801:3: note: in expansion of macro 'dev_warn'
> dev_warn(&client->dev,
Been' compiling through yocto, which puts compiler outputs in log files.
Warnings don't fail compilation so bitbake doesn't print them. Excuses,
excuses... shame.
V5!
