On Fri, May 24, 2019 at 04:22:28PM +0200, Marek Vasut wrote: > Add driver for the NXP TJA1100 and TJA1101 PHYs. These PHYs are special > BroadRReach 100BaseT1 PHYs used in automotive. > > Signed-off-by: Marek Vasut <[email protected]> > Cc: Andrew Lunn <[email protected]> > Cc: Florian Fainelli <[email protected]> > Cc: Guenter Roeck <[email protected]> > Cc: Heiner Kallweit <[email protected]> > Cc: Jean Delvare <[email protected]> > Cc: [email protected] > Reviewed-by: Florian Fainelli <[email protected]>
Reviewed-by: Andrew Lunn <[email protected]> > +static struct tja11xx_phy_stats tja11xx_hw_stats[] = { > + { "phy_symbol_error_count", 20, 0, GENMASK(15, 0) }, > + { "phy_polarity_detect", 25, 6, BIT(6) }, > + { "phy_open_detect", 25, 7, BIT(7) }, > + { "phy_short_detect", 25, 8, BIT(8) }, > + { "phy_rem_rcvr_count", 26, 0, GENMASK(7, 0) }, > + { "phy_loc_rcvr_count", 26, 8, GENMASK(15, 8) }, > +}; I don't like phy_polarity_detect, phy_open_detect and phy_short_detect since they are not actually counters. But we don't have cable test support yet. That is coming soon, but it is hard to say when, if it will get merged this cycle. So lets keep them, but don't be too surprised if they get removed later. Andrew
