Re: [PATCH V5] net: phy: tja11xx: Add TJA11xx PHY driver

[Andrew Lunn]

On Mon, May 27, 2019 at 08:44:24AM -0700, Guenter Roeck wrote:
> >+static u32 tja11xx_hwmon_in_config[] = {
> >+    HWMON_I_LCRIT_ALARM,
> >+    0
> >+};
> >+
> >+static const struct hwmon_channel_info tja11xx_hwmon_in = {
> >+    .type           = hwmon_in,
> >+    .config         = tja11xx_hwmon_in_config,
> >+};
> >+
> >+static u32 tja11xx_hwmon_temp_config[] = {
> >+    HWMON_T_CRIT_ALARM,
> >+    0
> >+};
> >+
> >+static const struct hwmon_channel_info tja11xx_hwmon_temp = {
> >+    .type           = hwmon_temp,
> >+    .config         = tja11xx_hwmon_temp_config,
> >+};
> >+
> >+static const struct hwmon_channel_info *tja11xx_hwmon_info[] = {
> >+    &tja11xx_hwmon_in,
> >+    &tja11xx_hwmon_temp,
> >+    NULL
> >+};
> >+
> You might want to consider using the new HWMON_CHANNEL_INFO() macro
> to simplify above boilerplate code.

Hi Guenter

That is a nice simplification. Could you run the semantic patch
in drivers/net/phy and submit the results.

Thanks
        Andrew