Re: [PATCH net-next v3 1/3] ethtool: Implement ethtool_puts()

[Andrew Lunn]

> +/**
> + * ethtool_puts - Write string to ethtool string data
> + * @data: Pointer to start of string to update

Isn't it actually a pointer to a pointer to the start of string to
update?

> +extern void ethtool_puts(u8 **data, const char *str);

        Andrew