> -----Original Message-----
> From: Jakub Kicinski <[email protected]>
> Sent: Thursday, March 7, 2024 10:29 AM
> To: Shradha Gupta <[email protected]>
> Cc: [email protected]; [email protected]; linux-
> [email protected]; [email protected]; Eric Dumazet
> <[email protected]>; Paolo Abeni <[email protected]>; Ajay Sharma
> <[email protected]>; Leon Romanovsky <[email protected]>; Thomas
> Gleixner <[email protected]>; Sebastian Andrzej Siewior
> <[email protected]>; KY Srinivasan <[email protected]>; Haiyang Zhang
> <[email protected]>; Wei Liu <[email protected]>; Dexuan Cui
> <[email protected]>; Long Li <[email protected]>; Michael Kelley
> <[email protected]>; Shradha Gupta <[email protected]>
> Subject: Re: [PATCH] net :mana : Add per-cpu stats for MANA device
>
> On Thu, 7 Mar 2024 06:52:12 -0800 Shradha Gupta wrote:
> > Extend 'ethtool -S' output for mana devices to include per-CPU packet
> > stats
>
> But why? You already have per queue stats.
Yes. But the q to cpu binding is dynamic, we also want the per-CPU stat
to analyze the CPU usage by counting the packets and bytes on each CPU.
>
> > Built-on: Ubuntu22
> > Tested-on: Ubuntu22
>
> I understand when people mention testing driver changes on particular
> SKUs of supported devices, that adds meaningful info. I don't understand
> what "built" and "tested" on a distro is supposed to tell us.
> Honest question, what is the value of this?
@Shradha Gupta Please add the tested SKU and test case here. Or, you don't
have to include test info with the patch.
Thanks,
- Haiyang
