On Thu, Mar 21, 2024 at 11:07:06AM -0700, Saurabh Singh Sengar wrote: > On Thu, Mar 21, 2024 at 04:42:44PM +0000, Long Li wrote: > > > Subject: [PATCH v2 5/7] tools: hv: Add new fcopy application based on uio > > > driver > > > > > > New fcopy application using uio_hv_generic driver. This application > > > copies file > > > from Hyper-V host to guest VM. > > > > > > A big part of this code is copied from tools/hv/hv_fcopy_daemon.c which > > > this new > > > application is replacing. > > > > > > Signed-off-by: Saurabh Sengar <[email protected]> > > > --- > > > [V2] > > > - Improve commit message. > > > - Change (4 * 4096) to 0x4000 for ring buffer size > > > - Removed some unnecessary type casting. > > > - Mentioned in file copy right header that this code is copied. > > > - Changed the print from "Registration failed" to "Signal to host failed". > > > - Fixed mask for rx buffer interrupt to 0 before waiting for interrupt. > > > > > > tools/hv/Build | 3 +- > > > tools/hv/Makefile | 10 +- > > > tools/hv/hv_fcopy_uio_daemon.c | 490 > > > +++++++++++++++++++++++++++++++++ > > > 3 files changed, 497 insertions(+), 6 deletions(-) create mode 100644 > > > tools/hv/hv_fcopy_uio_daemon.c > > > > > > diff --git a/tools/hv/Build b/tools/hv/Build index > > > 6cf51fa4b306..7d1f1698069b > > > 100644 > > > --- a/tools/hv/Build > > > +++ b/tools/hv/Build > > > @@ -1,3 +1,4 @@ > > > hv_kvp_daemon-y += hv_kvp_daemon.o > > > hv_vss_daemon-y += hv_vss_daemon.o > > > -hv_fcopy_daemon-y += hv_fcopy_daemon.o > > > +hv_fcopy_uio_daemon-y += hv_fcopy_uio_daemon.o hv_fcopy_uio_daemon-y > > > += > > > +vmbus_bufring.o > > > diff --git a/tools/hv/Makefile b/tools/hv/Makefile index > > > fe770e679ae8..944180cf916e 100644 > > > --- a/tools/hv/Makefile > > > +++ b/tools/hv/Makefile > > > > I'm not sure if vmbus_bufring will compile on ARM. > > If it's not supported, can use some flags in Makefile to not build this. > > You are right, this is not supported on ARM64. I can query uname in Makefile > and compile this only for arch != aarch64. > I will add this info in commit message as well. > > - Saurabh
Greg/Long, I will be sending the V3 fixing above comment. Hope there are no further comments. - Saurabh
