On Tue, Feb 11, 2025 at 01:51:55AM -0800, Erni Sri Satya Vennela wrote:
> Add debug statements to assist in debugging and monitoring
> driver behaviour, making it easier to identify potential
> issues during development and testing.
>
> Signed-off-by: Erni Sri Satya Vennela <[email protected]>
> ---
> .../net/ethernet/microsoft/mana/gdma_main.c | 52 +++++++++++++----
> .../net/ethernet/microsoft/mana/hw_channel.c | 6 +-
> drivers/net/ethernet/microsoft/mana/mana_en.c | 58 +++++++++++++++----
> 3 files changed, 94 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/net/ethernet/microsoft/mana/gdma_main.c
> b/drivers/net/ethernet/microsoft/mana/gdma_main.c
> index be95336ce089..f9839938f0ab 100644
> --- a/drivers/net/ethernet/microsoft/mana/gdma_main.c
> +++ b/drivers/net/ethernet/microsoft/mana/gdma_main.c
> @@ -666,8 +666,11 @@ int mana_gd_create_hwc_queue(struct gdma_dev *gd,
>
> gmi = &queue->mem_info;
> err = mana_gd_alloc_memory(gc, spec->queue_size, gmi);
> - if (err)
> + if (err) {
> + dev_err(gc->dev, "GDMA queue type: %d, size: %u, gdma memory
> allocation err: %d\n",
> + spec->type, spec->queue_size, err);
I would expect a debug statement to use dev_dbg(). Please update your
commit message.
> goto free_q;
> + }
>
> queue->head = 0;
> queue->tail = 0;
> @@ -688,6 +691,8 @@ int mana_gd_create_hwc_queue(struct gdma_dev *gd,
> *queue_ptr = queue;
> return 0;
> out:
> + dev_err(gc->dev, "Failed to create queue type %d of size %u, err: %d\n",
> + spec->type, spec->queue_size, err);
> mana_gd_free_memory(gmi);
> free_q:
> kfree(queue);
> @@ -763,14 +768,18 @@ static int mana_gd_create_dma_region(struct gdma_dev
> *gd,
>
> if (resp.hdr.status ||
> resp.dma_region_handle == GDMA_INVALID_DMA_REGION) {
> - dev_err(gc->dev, "Failed to create DMA region: 0x%x\n",
> - resp.hdr.status);
> err = -EPROTO;
> goto out;
> }
>
> gmi->dma_region_handle = resp.dma_region_handle;
> + dev_dbg(gc->dev, "Created DMA region handle 0x%llx\n",
> + gmi->dma_region_handle);
Given all the dev_err() you have added, do this add any value? Is
there a way out of this function which is not a success and does not
print an error?
Andrew
---
pw-bot: cr
