Since, the panic handlers may require certain cpus to be online to panic
gracefully, we should call them before turning off SMP. Without this
re-ordering, on Hyper-V hv_panic_vmbus_unload() times out, because the
vmbus channel is bound to VMBUS_CONNECT_CPU and unless the crashing cpu
is the same as VMBUS_CONNECT_CPU, VMBUS_CONNECT_CPU will be offlined by
crash_smp_send_stop() before the vmbus channel can be deconstructed.

Signed-off-by: Hamza Mahfooz <[email protected]>
---
 kernel/panic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/panic.c b/kernel/panic.c
index fbc59b3b64d0..9712a46dfe27 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -372,8 +372,6 @@ void panic(const char *fmt, ...)
        if (!_crash_kexec_post_notifiers)
                __crash_kexec(NULL);
 
-       panic_other_cpus_shutdown(_crash_kexec_post_notifiers);
-
        printk_legacy_allow_panic_sync();
 
        /*
@@ -382,6 +380,8 @@ void panic(const char *fmt, ...)
         */
        atomic_notifier_call_chain(&panic_notifier_list, 0, buf);
 
+       panic_other_cpus_shutdown(_crash_kexec_post_notifiers);
+
        panic_print_sys_info(false);
 
        kmsg_dump_desc(KMSG_DUMP_PANIC, buf);
-- 
2.47.1


Reply via email to