> -----Original Message-----
> From: Simon Horman <ho...@kernel.org>
> Sent: Monday, May 12, 2025 10:16 AM
> To: Haiyang Zhang <haiya...@microsoft.com>
> Cc: linux-hyperv@vger.kernel.org; net...@vger.kernel.org; Dexuan Cui
> <de...@microsoft.com>; step...@networkplumber.org; KY Srinivasan
> <k...@microsoft.com>; Paul Rosswurm <paul...@microsoft.com>;
> o...@aepfle.de; vkuzn...@redhat.com; da...@davemloft.net;
> wei....@kernel.org; eduma...@google.com; k...@kernel.org;
> pab...@redhat.com; l...@kernel.org; Long Li <lon...@microsoft.com>;
> ssen...@linux.microsoft.com; linux-r...@vger.kernel.org;
> dan...@iogearbox.net; john.fastab...@gmail.com; b...@vger.kernel.org;
> a...@kernel.org; h...@kernel.org; t...@linutronix.de;
> shradhagu...@linux.microsoft.com; andrew+net...@lunn.ch; linux-
> ker...@vger.kernel.org
> Subject: [EXTERNAL] Re: [PATCH net-next,v2] net: mana: Add handler for
> hardware servicing events
>
> On Fri, May 09, 2025 at 04:16:43PM -0700, Haiyang Zhang wrote:
> > To collaborate with hardware servicing events, upon receiving the
> special
> > EQE notification from the HW channel, remove the devices on this bus.
> > Then, after a waiting period based on the device specs, rescan the
> parent
> > bus to recover the devices.
> >
> > Signed-off-by: Haiyang Zhang <haiya...@microsoft.com>
> > ---
> > v2:
> > Added dev_dbg for service type as suggested by Shradha Gupta.
> > Added driver cap bit.
> >
> > ---
> > .../net/ethernet/microsoft/mana/gdma_main.c | 63 +++++++++++++++++++
> > include/net/mana/gdma.h | 11 +++-
> > 2 files changed, 72 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/microsoft/mana/gdma_main.c
> b/drivers/net/ethernet/microsoft/mana/gdma_main.c
>
> ...
>
> > +static void mana_serv_func(struct work_struct *w)
> > +{
> > + struct mana_serv_work *mns_wk = container_of(w, struct
> mana_serv_work, serv_work);
> > + struct pci_dev *pdev = mns_wk->pdev;
> > + struct pci_bus *bus, *parent;
>
> Please avoid lines wider than 80 columns in Networking code. In this case
> I would suggest separating the declaration and initialisation of mns_wk
> and
> pdev. Something like this (completely untested!):
>
> struct mana_serv_work *mns_wk;
> struct pci_bus *bus, *parent;
> struct pci_dev *pdev;
>
> mns_wk = container_of(w, struct mana_serv_work, serv_work);
> pdev = mns_wk->pdev;
Will update.
>
>
> ...
>
> > @@ -400,6 +441,28 @@ static void mana_gd_process_eqe(struct gdma_queue
> *eq)
> > eq->eq.callback(eq->eq.context, eq, &event);
> > break;
> >
> > + case GDMA_EQE_HWC_FPGA_RECONFIG:
> > + case GDMA_EQE_HWC_SOCMANA_CRASH:
> > + dev_dbg(gc->dev, "Recv MANA service type:%d\n", type);
> > +
> > + if (gc->in_service) {
> > + dev_info(gc->dev, "Already in service\n");
> > + break;
> > + }
> > +
> > + mns_wk = kzalloc(sizeof(*mns_wk), GFP_ATOMIC);
> > + if (!mns_wk) {
> > + dev_err(gc->dev, "Fail to alloc mana_serv_work\n");
>
> The memory allocator will log a message on error.
> So please don't also do so here.
Will remove this.
Thanks,
- Haiyang
