On Tue, Jun 24, 2025 at 04:33:42PM -0700, Jakub Kicinski wrote: > On Mon, 23 Jun 2025 04:14:01 -0700 Erni Sri Satya Vennela wrote: > > Fix build errors when CONFIG_NET_SHAPER is disabled, including: > > > > drivers/net/ethernet/microsoft/mana/mana_en.c:804:10: error: > > 'const struct net_device_ops' has no member named 'net_shaper_ops' > > > > 804 | .net_shaper_ops = &mana_shaper_ops, > > > > drivers/net/ethernet/microsoft/mana/mana_en.c:804:35: error: > > initialization of 'int (*)(struct net_device *, struct neigh_parms *)' > > from incompatible pointer type 'const struct net_shaper_ops *' > > [-Werror=incompatible-pointer-types] > > > > 804 | .net_shaper_ops = &mana_shaper_ops, > > You have to add > > select NET_SHAPER > > to kconfig dependencies for the driver. This symbol cannot be selected > by the user, its hidden from the menus. Thankyou for pointing it out Jakub. I'll make this change in the next version of this patch.
- Vennela > -- > pw-bot: cr
