> -----Original Message----- > From: Eric Dumazet <eduma...@google.com> > Sent: Tuesday, July 22, 2025 2:52 AM > To: Haiyang Zhang <haiya...@linux.microsoft.com> > Cc: linux-hyperv@vger.kernel.org; net...@vger.kernel.org; Haiyang Zhang > <haiya...@microsoft.com>; KY Srinivasan <k...@microsoft.com>; > wei....@kernel.org; k...@kernel.org; pab...@redhat.com; ho...@kernel.org; > da...@davemloft.net; s...@fomichev.me; kun...@google.com; > ahmed.z...@intel.com; aleksander.loba...@intel.com; linux- > ker...@vger.kernel.org; sta...@vger.kernel.org; #@linux.microsoft.com; > 5...@linux.microsoft.com > Subject: [EXTERNAL] Re: [PATCH net] net: core: Fix the loop in > default_device_exit_net() > > On Fri, Jul 18, 2025 at 1:21 PM Haiyang Zhang > <haiya...@linux.microsoft.com> wrote: > > > > From: Haiyang Zhang <haiya...@microsoft.com> > > > > The loop in default_device_exit_net() won't be able to properly detect > the > > head then stop, and will hit NULL pointer, when a driver, like > hv_netvsc, > > automatically moves the slave device together with the master device. > > > > To fix this, add a helper function to return the first migratable netdev > > correctly, no matter one or two devices were removed from this net's > list > > in the last iteration. > > > > Cc: sta...@vger.kernel.org # 5.4+ > > We (network maintainers) prefer a Fixes: tag, so that we can look at > the blamed patch, rather than trusting your '5.4' hint. > > Without a Fixes tag, you are forcing each reviewer to do the > archeology work, and possibly completely miss your point.
Thanks. I will have the Fixes tag in the new patch. - Haiyang
