On Sat, Sep 13, 2025 at 10:12 PM Andrew Lunn <and...@lunn.ch> wrote:
> I'm confused with your commit message. You say DUPLEX used to be > reported as Full if the speed is known. How does c268ca6087f55 change > this? Because in some circumstances like Azure, mlx5e_port_ptys2speed (now mlx5_port_ptys2info) does not return a speed. And thus it relies on data_rate_oper. It reads to me as long as there's no issue acquiring the speed duplex should be set to full. > You don't say in the commit message. Why is Half duplex > important to this fix? I don't see Half anywhere in the code. It does not return half duplex at all. It would be unknown. I'm just saying that half duplex shouldn't exist in modern Mellanox 5. > Also, what sort of problems do you see with duplex unknown? There were reports of RHEL seeing duplex unknown in ethtool on Azure Mellanox 5. The intention is to fix this. Thanks for reviewing. Li Tian
