On Mon, Oct 27, 2025 at 03:18:35PM +0100, Borislav Petkov wrote: > On Thu, Oct 16, 2025 at 07:57:24PM -0700, Ricardo Neri wrote: > > arch/x86/kernel/acpi/madt_wakeup.c | 76 ---------------------------------- > > arch/x86/kernel/smpwakeup.c | 83 > > ++++++++++++++++++++++++++++++++++++++ > > How does ACPI-related code belong in the arch/x86/kernel/ hierarchy? > > Not to mention that arch/x86/kernel/ is a dumping ground for everything *and* > the kitchen sink so we should not put more crap in there...
Right. All the functions in the file start with the acpi_ prefix. It could be kept under arch/x86/kernel/acpi/. The Kconfig symbol X86_MAILBOX_WAKEUP would have to live in arch/x86/Kconfig as there is no Kconfig file under arch/x86/kernel/acpi. ACPI_MADT_WAKEUP is arch/x86/Kconfig. Does that sound acceptable? Thank you for your feedback, Boris, Best, Ricardo
