On 11/5/2025 11:04 AM, Erni Sri Satya Vennela wrote:
> Once the netshaper is created for MANA, the current bandwidth
> is reported in debugfs like this:
>
> $ sudo ./tools/net/ynl/pyynl/cli.py \
> --spec Documentation/netlink/specs/net_shaper.yaml \
> --do set \
> --json '{"ifindex":'3',
> "handle":{ "scope": "netdev", "id":'1' },
> "bw-max": 200000000 }'
> None
>
> $ sudo cat /sys/kernel/debug/mana/1/vport0/current_speed
> 200
>
> After the shaper is deleted, it is expected to report
> the maximum speed supported by the SKU. But currently it is
> reporting 0, which is incorrect.
>
> Fix this inconsistency, by resetting apc->speed to apc->max_speed
> during deletion of the shaper object. This will improve
> readability and debuggability.
>
> Signed-off-by: Erni Sri Satya Vennela <[email protected]>
> ---Reviewed-by: Jacob Keller <[email protected]> > Changes in v3: > * Remove Fixes tag.> Changes in v2: > * Add Fixes tag. > --- > drivers/net/ethernet/microsoft/mana/mana_en.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c > b/drivers/net/ethernet/microsoft/mana/mana_en.c > index 0142fd98392c..9d56bfefd755 100644 > --- a/drivers/net/ethernet/microsoft/mana/mana_en.c > +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c > @@ -814,7 +814,7 @@ static int mana_shaper_del(struct net_shaper_binding > *binding, > /* Reset mana port context parameters */ > apc->handle.id = 0; > apc->handle.scope = NET_SHAPER_SCOPE_UNSPEC; > - apc->speed = 0; > + apc->speed = apc->max_speed; > } > > return err;
OpenPGP_signature.asc
Description: OpenPGP digital signature
