Sashiko points out that mana_ib_cfg_vport_steering() is leaked, the normal
destroy path cleans it up.

Cc: [email protected]
Fixes: 0266a177631d ("RDMA/mana_ib: Add a driver for Microsoft Azure Network 
Adapter")
Link: 
https://sashiko.dev/#/patchset/0-v1-e911b76a94d1%2B65d95-rdma_udata_rep_jgg%40nvidia.com?part=4
Signed-off-by: Jason Gunthorpe <[email protected]>
---
 drivers/infiniband/hw/mana/qp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/mana/qp.c b/drivers/infiniband/hw/mana/qp.c
index 645581359cee0b..f503445a38f2d8 100644
--- a/drivers/infiniband/hw/mana/qp.c
+++ b/drivers/infiniband/hw/mana/qp.c
@@ -215,13 +215,15 @@ static int mana_ib_create_qp_rss(struct ib_qp *ibqp, 
struct ib_pd *pd,
                ibdev_dbg(&mdev->ib_dev,
                          "Failed to copy to udata create rss-qp, %d\n",
                          ret);
-               goto fail;
+               goto err_disable_vport_rx;
        }
 
        kfree(mana_ind_table);
 
        return 0;
 
+err_disable_vport_rx:
+       mana_disable_vport_rx(mpc);
 fail:
        while (i-- > 0) {
                ibwq = ind_tbl->ind_tbl[i];
-- 
2.43.0


Reply via email to