> > Sashiko points out that the user can specify WQs sharing the same CQ as a > part of > the uAPI and this will trigger the WARN_ON() then go on to corrupt the kernel. > > Just reject it outright and fail the QP creation. > > Cc: [email protected] > Fixes: c15d7802a424 ("RDMA/mana_ib: Add CQ interrupt support for RAW QP") > Link: > https://sashiko.d/ > ev%2F%23%2Fpatchset%2F0-v2-1c49eeb88c48%252B91- > rdma_udata_rep_jgg%2540nvidia.com%3Fpart%3D1&data=05%7C02%7Clongli% > 40microsoft.com%7C05b55740f97741c63c8408dea541ba1a%7C72f988bf86f141 > af91ab2d7cd011db47%7C1%7C0%7C639129898905286592%7CUnknown%7CT > WFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4 > zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=045NsQ2efi > m0Mmc8EGeKWQ3pyFbs63%2B2023OvD3%2B8IM%3D&reserved=0 > Signed-off-by: Jason Gunthorpe <[email protected]>
Reviewed-by: Long Li <[email protected]> > --- > drivers/infiniband/hw/mana/cq.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/infiniband/hw/mana/cq.c b/drivers/infiniband/hw/mana/cq.c > index f4cbe21763bf11..2d682428ef202a 100644 > --- a/drivers/infiniband/hw/mana/cq.c > +++ b/drivers/infiniband/hw/mana/cq.c > @@ -137,8 +137,9 @@ int mana_ib_install_cq_cb(struct mana_ib_dev *mdev, > struct mana_ib_cq *cq) > > if (cq->queue.id >= gc->max_num_cqs) > return -EINVAL; > - /* Create CQ table entry */ > - WARN_ON(gc->cq_table[cq->queue.id]); > + /* Create CQ table entry, sharing a CQ between WQs is not supported */ > + if (gc->cq_table[cq->queue.id]) > + return -EINVAL; > if (cq->queue.kmem) > gdma_cq = cq->queue.kmem; > else > -- > 2.43.0
