Am 27.05.26 um 17:19 schrieb [email protected]: [...]
[Severity: High] By no longer setting plane_state->fb_damage_clips to NULL during a modeset, will this break drivers that bypass the damage iterator?
No drivers bypass the damage iterator. Doing so would be an error.
Drivers like AMDGPU (in fill_dc_dirty_rects) and vmwgfx directly call drm_plane_get_damage_clips_count() and drm_plane_get_damage_clips(). Because these accessor functions do not check the new ignore_damage_clips flag, won't they see a non-zero clip count if userspace provided one? If they see a non-zero clip count during a modeset, will they incorrectly skip their fallback paths and perform a partial update instead of the required full framebuffer update?
-- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
